Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer info on customizing i18n strings #1345

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Clearer info on customizing i18n strings #1345

merged 3 commits into from
Jan 9, 2023

Conversation

LisaFC
Copy link
Collaborator

@LisaFC LisaFC commented Jan 6, 2023

Made this info clearer as I'd actually forgotten you could do this until #1331

Made this info clearer as I'd actually forgotten you could do this until #1331
@LisaFC LisaFC requested a review from deining January 6, 2023 16:36
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@LisaFC LisaFC merged commit 6607d41 into main Jan 9, 2023
@LisaFC LisaFC deleted the LisaFC-strings branch January 9, 2023 15:14
dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
* Clearer info on customizing i18n strings

Made this info clearer as I'd actually forgotten you could do this until google#1331

* Implementing deining's suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants