Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BSv5][JS]: fix dropdowns and more #1382

Merged
merged 1 commit into from
Feb 11, 2023
Merged

[BSv5][JS]: fix dropdowns and more #1382

merged 1 commit into from
Feb 11, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jan 29, 2023

This PR closes #1381.
It also bumps jquery script to latest released version.

@deining deining force-pushed the bs5-dropdown branch 2 times, most recently from 7674389 to ffc8a8b Compare February 2, 2023 21:39
chalin
chalin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm feeling that maybe some more cleanup is needed in base.js, but we can look at that after this PR is merged.

@chalin chalin changed the title [BSv5]: further improvements [BSv5][JS]: fix dropdowns and more Feb 11, 2023
@chalin chalin merged commit fcf5074 into google:main Feb 11, 2023
This was referenced Feb 11, 2023
Closed
Merged
@deining deining deleted the bs5-dropdown branch February 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BSv5] Dropdown for language selection fails
2 participants
@deining @chalin