-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shortcode for accordion component (Bootstrap 5) #1391
base: main
Are you sure you want to change the base?
Conversation
74a6cd7
to
f9ffe80
Compare
the Collapse component too! https://getbootstrap.com/docs/5.2/components/collapse/ |
e8670f4
to
82ee61b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this! I left a few nits on the user guide text.
e653353
to
2196693
Compare
You are welcome!
Thanks for your review and your helpful comments. All proposed changes are incorporated now. |
This PR adds two shortcodes
accordion
andaccordion-item
in order to allow authoring of a accordion components. You will encounter this element frequently on various websites, e.g. for FAQ sections. The markup for an accordion is similar to the markup for creating a tabbed pane. For a preview have a look at the implementation details and the documentation given here:https://deploy-preview-1391--docsydocs.netlify.app/docs/adding-content/shortcodes/#accordion
This PR makes use of the accordion component introduced with bootstrap 5.
I hope you like the feature.