Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: shortcode imgproc does not work with % for markdown body (#332) #1397

Closed
wants to merge 0 commits into from

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 9, 2023

This PR is part of #906. It contains a fix addressing and closing #332:

Two actions were needed in order to fix the issue:

  • remove indentation (as correctly mentioned when raising the issue)
  • adding a comment line in oder to fulfill the end condition of the html block containing the shortcode body (as defined in the CommonMark spec, number 7).

The PR also adds a paragraph to the user guide explaining the proper use of the shortcode with different markups (markdown/html).

@deining
Copy link
Collaborator Author

deining commented May 25, 2023

Inadvertently closed, reopened with #1522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shortcodes Hugo shortcodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant