Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: add license and homepage #1428

Merged
merged 2 commits into from
Feb 24, 2023
Merged

package.json: add license and homepage #1428

merged 2 commits into from
Feb 24, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 16, 2023

This PR corrects an issue reported with #1421.

When running npm view, incorrect license information is printed:

$ npm view deining/docsy

docsy@0.6.0 | Proprietary | deps: 2 | versions: 1

...

@deining deining added e0-minutes Effort < 60 min p3-low labels Feb 16, 2023
@deining deining requested a review from chalin February 16, 2023 15:04
chalin
chalin approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped up the version. Thanks for this PR.

@chalin chalin merged commit 6f796f9 into google:main Feb 24, 2023
@deining deining deleted the npm-licénse branch February 24, 2023 13:12
@chalin chalin mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
e0-minutes Effort < 60 min p3-low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deining @chalin