Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Adjusted offline search popover #1429

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

tekezo
Copy link
Contributor

@tekezo tekezo commented Feb 16, 2023

  • Closes Offline search no longer works under Bootstrap v5 #1425
  • Stop using $targetSearchInput.popover.
  • Move popover options to new bootstrap.Popover constructor from $searchInput.data.
  • Use customClass option to add td-offline-search-results class instead of using template option.
  • Fixed an issue that shown.bs.popover is called more times than required when popover is shown multiple times.

Screenshot 2023-02-17 at 0 42 22

@LisaFC
Copy link
Collaborator

LisaFC commented Feb 21, 2023

This looks great. @chalin does this fix the issue?

@chalin
Copy link
Collaborator

chalin commented Feb 22, 2023

Looks promising! 😄 Will carefully review as soon as I can. Thanks!

@chalin
Copy link
Collaborator

chalin commented Feb 22, 2023

Lovely! Here are some more screen shots, for the record:

image
image

I generated these from the site using this diff:

diff --git a/userguide/hugo.yaml b/userguide/hugo.yaml
index 54ef664..cc7aa7d 100644
--- a/userguide/hugo.yaml
+++ b/userguide/hugo.yaml
@@ -58,9 +58,9 @@ params:
   time_format_blog: Monday, January 02, 2006
   time_format_default: January 2, 2006
   rss_sections: [blog] # TODO: drop since this is the default
-  gcs_engine_id: 011217106833237091527:la2vtv2emlw
+  # gcs_engine_id: 011217106833237091527:la2vtv2emlw
   algolia_docsearch: false
-  offlineSearch: false
+  offlineSearch: true
   offlineSearchSummaryLength: 70
   offlineSearchMaxResults: 10
   prism_syntax_highlighting: false

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@chalin chalin merged commit cd3a69e into google:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline search no longer works under Bootstrap v5
4 participants