-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BSv5] Refactor Click-to-copy #1447
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,86 +1,47 @@ | ||
| let codeListings = document.querySelectorAll('.highlight > pre'); | ||
|
|
||
| for (let index = 0; index < codeListings.length; index++) | ||
| { | ||
| for (let index = 0; index < codeListings.length; index++) { | ||
| const codeSample = codeListings[index].querySelector('code'); | ||
| const copyButton = document.createElement("button"); | ||
| copyButton.setAttribute('type', 'button'); | ||
| copyButton.onclick = function() { copyCode(codeSample); }; | ||
| copyButton.classList.add('fas', 'fa-copy'); | ||
| const copyButton = document.createElement('button'); | ||
| const buttonAttributes = { | ||
| type: 'button', | ||
| title: 'Copy to clipboard', | ||
| 'data-bs-toggle': 'tooltip', | ||
| 'data-bs-placement': 'top', | ||
| 'data-bs-container': 'body', | ||
| }; | ||
|
|
||
| Object.keys(buttonAttributes).forEach((key) => { | ||
| copyButton.setAttribute(key, buttonAttributes[key]); | ||
| }); | ||
|
|
||
| const buttonTooltip = document.createElement('div'); | ||
| buttonTooltip.classList.add('c2c-tooltip'); | ||
| buttonTooltip.setAttribute('role', 'tooltip'); | ||
| buttonTooltip.innerHTML += 'Copy to clipboard'; | ||
| copyButton.classList.add( | ||
| 'fas', | ||
| 'fa-copy', | ||
| 'btn', | ||
| 'btn-dark', | ||
| 'btn-sm', | ||
| 'td-click-to-copy' | ||
| ); | ||
| const tooltip = new bootstrap.Tooltip(copyButton); | ||
|
|
||
| copyButton.onclick = () => { | ||
| copyCode(codeSample); | ||
| copyButton.setAttribute('data-bs-original-title', 'Copied!'); | ||
| tooltip.show(); | ||
| }; | ||
|
|
||
| copyButton.onmouseout = () => { | ||
| copyButton.setAttribute('data-bs-original-title', 'Copy to clipboard'); | ||
| tooltip.hide(); | ||
| }; | ||
|
|
||
| const buttonDiv = document.createElement('div'); | ||
| buttonDiv.classList.add('click-to-copy'); | ||
|
|
||
| // Use Popper to create and handle the tooltip behavior. | ||
|
|
||
| const popperInstance = Popper.createPopper(copyButton, buttonTooltip, | ||
| { | ||
| modifiers: | ||
| [ | ||
| { | ||
| name: 'offset', | ||
| options: | ||
| { | ||
| offset: [0, -48], | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| copyButton.addEventListener('click', () => | ||
| { | ||
| buttonTooltip.innerHTML = 'Copied!'; | ||
| }); | ||
|
|
||
| copyButton.addEventListener('mouseenter', () => | ||
| { | ||
| buttonTooltip.setAttribute('show-tooltip', ''); | ||
|
|
||
| // Enable eventListeners when the code block is on the viewport | ||
|
|
||
| popperInstance.setOptions((options) => ({ | ||
| ...options, | ||
| modifiers: | ||
| [ | ||
| ...options.modifiers, | ||
| { name: 'eventListeners', enabled: true }, | ||
| ], | ||
| })); | ||
| popperInstance.update(); | ||
| }); | ||
|
|
||
| copyButton.addEventListener('mouseleave', () => | ||
| { | ||
| buttonTooltip.removeAttribute('show-tooltip'); | ||
|
|
||
| // Reset the message in case the button was clicked | ||
| buttonTooltip.innerHTML = 'Copy to clipboard'; | ||
|
|
||
| // Disble eventListeners when the code block is NOT on the viewport | ||
|
|
||
| popperInstance.setOptions((options) => ({ | ||
| ...options, | ||
| modifiers: | ||
| [ | ||
| ...options.modifiers, | ||
| { name: 'eventListeners', enabled: false }, | ||
| ], | ||
| })); | ||
| }); | ||
|
|
||
| buttonDiv.append(copyButton); | ||
| buttonDiv.append(buttonTooltip); | ||
| codeListings[index].insertBefore(buttonDiv, codeSample); | ||
|
|
||
| } | ||
|
|
||
| function copyCode(codeSample) | ||
| { | ||
| navigator.clipboard.writeText(codeSample.textContent.trim()); | ||
| } | ||
|
|
||
| const copyCode = (codeSample) => { | ||
| navigator.clipboard.writeText(codeSample.textContent.trim() + '\n'); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work for
0.6.0and we haven't definitely decided on the next version number. I think "later than" covers that. About the article "the", although I know I don't really need it here, I try to never omit it based on this guideline: https://developers.google.com/style/articles