Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop AnchorJS in favor of Hugo markdown render hook #1463

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Drop AnchorJS in favor of Hugo markdown render hook #1463

merged 1 commit into from
Feb 2, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Mar 7, 2023 •
edited by chalin
Loading

This PR addresses #1460. It drops assets/js/anchor.js in favor of a Hugo markdown render hook. This comes with these advantages:

  • markup is generated statically now and doesn't depend on javascript any more
  • some jquery code is dropped (Drop jQuery #1436)

This PR contributes to #1460.

Preview: https://deploy-preview-1463--docsydocs.netlify.app/docs/

@deining deining added e0-minutes Effort < 60 min CI/infra CI & infrastructure labels Mar 7, 2023
@deining deining requested a review from chalin March 7, 2023 13:03
@chalin chalin changed the title Drop AnchorJS in favor of Hugo markdown render hook (#1460) Drop AnchorJS in favor of Hugo markdown render hook May 31, 2023
@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 23Q4 Nov 29, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Jan 11, 2024
@chalin chalin mentioned this pull request Feb 2, 2024
Closed
33 tasks
chalin
chalin approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin chalin merged commit a4eaf8f into google:main Feb 2, 2024
11 checks passed
@chalin chalin mentioned this pull request Feb 2, 2024
Closed
3 tasks
@deining deining deleted the drop-anchorjs branch February 2, 2024 14:13
@chalin chalin mentioned this pull request Feb 4, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure e0-minutes Effort < 60 min
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deining @chalin