Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] blocks/cover row-col hierarchy fix #1467

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 8, 2023

Preview:


Screenshots

Screenshots of the homepage cover. You can also compare the About page covers.

Originally (under BSv4):

image

Before this PR:

image

With this PR's fix:

image

@LisaFC
Copy link
Collaborator

LisaFC commented Mar 8, 2023

This looks really good! I've tried it at multiple widths and it all works well.

@chalin
Copy link
Collaborator Author

chalin commented Mar 8, 2023

Great, thanks for testing it out!

@chalin chalin merged commit c05c214 into google:main Mar 8, 2023
@chalin chalin deleted the chalin-im-blocks-cover-fix-2023-03-08 branch March 8, 2023 14:15
@chalin chalin changed the title [BSv5] blocks/cover row/col fix [BSv5] blocks/cover row-col hierarchy fix Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants