Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] fix main container height #1501

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

yann-soubeyrand
Copy link
Contributor

Setting a minimum height instead of a fixed height fixes footer overflow issues.

Before:
Capture d’écran du 2023-04-21 19-28-30

After:
Capture d’écran du 2023-04-21 19-28-52

Setting a minimum height instead of a fixed height fixes footer overflow
issues.

Signed-off-by: Yann Soubeyrand <yann.soubeyrand@gmx.fr>
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin changed the title css: fix main container height [BSv5] fix main container height May 26, 2023
@chalin chalin merged commit f22a70e into google:main May 26, 2023
6 checks passed
@yann-soubeyrand yann-soubeyrand deleted the fix-height branch May 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants