Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] fix horizontal scrollbar issues #1502

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

yann-soubeyrand
Copy link
Contributor

IIUC, Bootstrap row has negative left and right margins to counteract col padding (https://getbootstrap.com/docs/5.3/layout/grid/#how-it-works). Setting col padding to 0 can lead to issues where a pointless horizontal scrollbar is added to the browser window.

Before:
Capture d’écran du 2023-04-21 19-39-00

After:
Capture d’écran du 2023-04-21 19-39-13

IIUC, Bootstrap row has negative left and right margins to counteract
col padding (https://getbootstrap.com/docs/5.3/layout/grid/#how-it-works).
Setting col padding to 0 can lead to issues where a pointless horizontal
scrollbar is added to the browser window.

Signed-off-by: Yann Soubeyrand <yann.soubeyrand@gmx.fr>
@chalin
Copy link
Collaborator

chalin commented May 25, 2023

@chalin chalin linked an issue May 25, 2023 that may be closed by this pull request
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin changed the title css: fix horizontal scrollbar issues [BSv5] fix horizontal scrollbar issues May 25, 2023
@chalin chalin merged commit 454b6f1 into google:main May 25, 2023
6 checks passed
@yann-soubeyrand yann-soubeyrand deleted the fix-width branch May 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

home page is showing horizontal scroller at bottom of site
2 participants