Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks/feature fix #1503

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Blocks/feature fix #1503

merged 6 commits into from
Feb 8, 2024

Conversation

fekete-robert
Copy link
Collaborator

This PR:

  • Documents the so far undocumented url_text parameter
  • Changes the shortcode so it doesn't automatically add an ellipsis if url_text is set

deining
deining approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

layouts/shortcodes/blocks/feature.html Outdated Show resolved Hide resolved
@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
chalin
chalin reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shortcode could use some cleanup, but it'll do for now. Copyedit suggestion inline. Thanks.

userguide/content/en/docs/adding-content/shortcodes/index.md Outdated Show resolved Hide resolved
This was referenced Feb 2, 2024
Closed
Closed
@chalin
Copy link
Collaborator

chalin commented Feb 2, 2024

@fekete-robert - was this PR in response to an issue? I'm not finding anything after a quick search; so, I've created the following issue -- let's discuss alternative solutions there:

@fekete-robert
Copy link
Collaborator Author

@chalin No, there wasn't any issue IIRC, I just needed the same feature and realized it was already there just not documented.

@fekete-robert
Copy link
Collaborator Author

And I added the part about the ellipsis because it didn't make sense with the text we used, and figured it might be the case for others as well.

@chalin
Copy link
Collaborator

chalin commented Feb 3, 2024

Thanks for the clarifications @fekete-robert. My suggestion would be to reduce the scope of this PR to the doc-page update only. Once we settle on a solution to #1820, another PR can be submitted. I'm looking forward to discussing this with @emckean.

chalin
chalin approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per PSC meeting, I've dropped the ellipsis \o/
And tweak the table Default-description prose.
LGTM now. Thanks @fekete-robert.

@chalin chalin merged commit fe067f3 into google:main Feb 8, 2024
11 checks passed
@chalin chalin mentioned this pull request Feb 8, 2024
Merged
@fekete-robert fekete-robert deleted the blocks/feature-fix branch February 14, 2024 11:37
@chalin chalin removed this from the 24Q2 milestone Apr 2, 2024
@chalin chalin added this to the 24Q1 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deining deining deining approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.
3 participants
@fekete-robert @chalin @deining