Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle svg hero images in blocks/cover shortcode #1505

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Handle svg hero images in blocks/cover shortcode #1505

merged 2 commits into from
Feb 2, 2024

Conversation

fekete-robert
Copy link
Collaborator

No description provided.

@chalin chalin requested review from deining and geriom May 31, 2023 15:52
chalin
chalin reviewed May 31, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.
WDYT @deining @geriom?

@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 23Q4 Nov 30, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Jan 11, 2024
chalin
chalin approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace clean up, otherwise LGTM

layouts/shortcodes/blocks/cover.html Outdated Show resolved Hide resolved
@fekete-robert @chalin
Update layouts/shortcodes/blocks/cover.html
b5c2dce 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@fekete-robert
Copy link
Collaborator Author

Thanks for the review, @chalin !

chalin
chalin approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fekete-robert

@chalin chalin merged commit e22aec4 into google:main Feb 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@deining deining Awaiting requested review from deining

@geriom geriom Awaiting requested review from geriom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.
2 participants
@fekete-robert @chalin