Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hugo to 0.112.3 and fix en title #1534

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 2, 2023

This PR updates hugo to version 0.112.3.
This PR closes #1531.

@deining deining requested a review from chalin June 2, 2023 20:57
@deining deining added this to the 23Q2 milestone Jun 2, 2023
@deining deining added CI/infra CI & infrastructure dependencies Pull requests that update a dependency file labels Jun 2, 2023
@deining deining changed the title Upgrade Hugo to 0.112.7 (#1531) Upgrade Hugo to 0.112.3 (#1531) Jun 2, 2023
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin chalin merged commit b51ab5d into google:main Jun 5, 2023
@chalin chalin changed the title Upgrade Hugo to 0.112.3 (#1531) Upgrade Hugo to 0.112.3 Jun 5, 2023
@chalin
Copy link
Collaborator

chalin commented Jun 5, 2023

Darn, I knew that I should have built and diffed locally first! 🤷🏼‍♂️ There's still a problem, see:

@chalin chalin changed the title Upgrade Hugo to 0.112.3 Upgrade Hugo to 0.112.3 and fix en title Jun 5, 2023
@chalin chalin changed the title Upgrade Hugo to 0.112.3 and fix en title Upgrade Hugo to 0.112.3 and fix en title Jun 5, 2023
@deining deining deleted the hugo-v0.112 branch November 13, 2023 06:14
@@ -33,10 +33,10 @@ services:

languages:
en:
title: Docsy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, title isn't a custom parameter and shouldn't have been moved to be under params. In fact, we don't need a title parameter here, so it is being dropped in #1994.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No more og:site_name when building under Hugo 0.112.x
2 participants