Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: correct min_version in theme.toml #1553

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Fix: correct min_version in theme.toml #1553

merged 2 commits into from
Jun 8, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 7, 2023

This PR corrects a warning introduced with #1546.

WARN 2023/06/07 22:46:37 Failed to read module config for "github.com/google/docsy"
in "/tmp/hugo_cache/modules/filecache/modules/pkg/mod/github.com/google/docsy@v0.6.1-0.20230607204327-bae56a339ea1/theme.toml": "_stream.toml:8:20":
unmarshal failed: toml: float can have at most one decimal point

chalin
chalin reviewed Jun 7, 2023
View reviewed changes
theme.toml Outdated Show resolved Hide resolved
chalin
chalin approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confirming that the warning is gone: https://app.netlify.com/sites/docsydocs/deploys/6481f0e4898aae0008539500

@chalin chalin merged commit f726510 into google:main Jun 8, 2023
@deining deining deleted the fix-theme.toml branch June 11, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @chalin