Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 5.3.3 #1563

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Upgrade to Bootstrap 5.3.3 #1563

merged 4 commits into from
Mar 6, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 11, 2023

This PR follows up on #1510 and #1528.
It updates bootstrap dependency to latest released version 5.3.3.

@deining deining force-pushed the bootstrap_v5.3 branch 3 times, most recently from 37b72a2 to f1a2106 Compare June 12, 2023 15:36
@deining deining mentioned this pull request Jun 16, 2023
4 tasks
@deining deining force-pushed the bootstrap_v5.3 branch 2 times, most recently from be15a5b to 2e9fde8 Compare July 28, 2023 21:41
@deining deining changed the title Upgrade to Bootstrap 5.3 Upgrade to Bootstrap 5.3.1 Jul 28, 2023
@deining deining requested a review from chalin July 28, 2023 21:42
@deining
Copy link
Collaborator Author

deining commented Jul 28, 2023

Bootstrap is at version 5.3.1 meanwhile. This is now reflected in this PR.

@deining deining added dependencies Pull requests that update a dependency file module e0-minutes Effort < 60 min labels Jul 29, 2023
@deining deining mentioned this pull request Jul 27, 2023
14 tasks
@deining deining changed the title Upgrade to Bootstrap 5.3.1 Upgrade to Bootstrap 5.3.2 Nov 4, 2023
@deining
Copy link
Collaborator Author

deining commented Nov 4, 2023

Bootstrap is at version 5.3.2 meanwhile. This is now reflected in this PR.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the following clarifying remark at the start of the opening comment of #1528:

BS 5.3 changes are significant enough that, IMHO, we'll want to careful walkthrough of the 5.3 migration details before upgrading Docsy to BS 5.3

All this to say that this PR could be the first to be merged, but only once we're ready to start the migration to 5.3. Which probably won't happen until 24Q1 since I'd like to give non-Bootstrap related issues some love before the year is out.

Of course, feel free to update the PR in the meantime, or you can wait until later.

/cc @LisaFC @geriom @emckean

@chalin
Copy link
Collaborator

chalin commented Mar 6, 2024

@deining - I'll have time this month to devote to the BS 5.3 upgrade. Do you want to resolve and update this PR or submit a new one?

@chalin chalin added this to the 24Q1 milestone Mar 6, 2024
@deining deining changed the title Upgrade to Bootstrap 5.3.2 Upgrade to Bootstrap 5.3.3 Mar 6, 2024
@deining
Copy link
Collaborator Author

deining commented Mar 6, 2024

@deining - I'll have time this month to devote to the BS 5.3 upgrade.

Great to hear that!

Do you want to resolve and update this PR

Done:

  • resolved merge conflicts
  • updated to latest Bootstrap version 5.3.3

Good luck with your further work!

@chalin
Copy link
Collaborator

chalin commented Mar 6, 2024

Thanks for the quick update.

@chalin chalin merged commit 2a8b210 into google:main Mar 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file e0-minutes Effort < 60 min module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants