Improve compile-time detection of Bootstrap version #1579

chalin · 2023-06-16T15:11:39Z

Closes [BSv5] Provide more reliable (and optional) detection of Bootstrap 5 #1574
Places BS version test in a separate SCSS file named assets/scss/support/_bootstrap_vers_test.scss.
To disable the test, all a project has to do is create an empty file of the same name.
The new test is intended to result in, at worst, a false negative (fail to detect BSv4) rather than a false positive (incorrectly think BS is at v4) -- as was reported in Release 0.7.0 #1555 (reply in thread)

deining

LGTM.

chalin · 2023-06-16T15:41:32Z

Will merge now. Feedback is still welcome.

chalin added the dependencies Pull requests that update a dependency file label Jun 16, 2023

chalin requested review from deining and geriom June 16, 2023 15:11

chalin changed the title ~~Improve BS version compile-time detection~~ Improve compile-time detection of Bootstrap version Jun 16, 2023

deining approved these changes Jun 16, 2023

View reviewed changes

Improve BS version compile-time detection

6040fc8

chalin force-pushed the chalin-im-bs-vers-test-2023-06-16 branch from bad9042 to 6040fc8 Compare June 16, 2023 15:41

chalin merged commit 5260bce into google:main Jun 16, 2023

chalin deleted the chalin-im-bs-vers-test-2023-06-16 branch June 16, 2023 15:43

Provide feedback