Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UG landing page rework of CTA and subtitle #1581

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 16, 2023

  • Drops icons from CTA buttons, as discussed during the last PSC meeting
  • Moves page subtitle into description field, so that it can populate the description meta elements, and be used in the page too.
  • Changes page element order to: title, subtitle, CTA buttons
  • Preview: https://deploy-preview-1581--docsydocs.netlify.app
Before After
image image

@chalin chalin force-pushed the chalin-im-ug-landing-cleanup-2023-06-16 branch from ce574ea to 5569e78 Compare June 16, 2023 16:30
@chalin chalin force-pushed the chalin-im-ug-landing-cleanup-2023-06-16 branch 2 times, most recently from aeb53c4 to 9bf790c Compare June 16, 2023 16:35
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chalin chalin force-pushed the chalin-im-ug-landing-cleanup-2023-06-16 branch from 9bf790c to 6303d70 Compare June 26, 2023 19:14
@chalin chalin force-pushed the chalin-im-ug-landing-cleanup-2023-06-16 branch from 6303d70 to 6fb946b Compare June 26, 2023 19:20
@@ -1,17 +1,15 @@
---
title: Docsy
description: A Hugo theme for creating great technical documentation sites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for the slogan, shuffling the words a bit: "A great Hugo theme for technical documentation sites"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriom - thanks for the review. I reused the current site description. Let's discuss the possibility of updating it at our next PSC meeting (I've added an entry to our meeting notes).

@chalin chalin merged commit 933829f into google:main Jun 26, 2023
5 checks passed
@chalin chalin deleted the chalin-im-ug-landing-cleanup-2023-06-16 branch June 26, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants