User guide: do not enable mermaid and scripts globally #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
ug-scripts-mermaid
branch
from
1181a76
to
ac089df
Compare
chalin
approved these changes
Jun 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mermaid scripts are globally enabled in the user guide. This confuses users, as seen in #1588. This PR corrects this so that mermaid scripts are only inserted for pages that actually contain mermaid code blocks.
Note: Globally enabling mermaid scripts is due to legacy code (hugo <
v0.93.0). We should do some cleanup here. I will open a separate issue for this.