Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: Support dartsass as transpiler #1598

Merged
merged 1 commit into from
Jul 27, 2023
Merged

css: Support dartsass as transpiler #1598

merged 1 commit into from
Jul 27, 2023

Conversation

deining
Copy link
Collaborator

@deining deining commented Jun 30, 2023

When trying to run docsy theme with dart sass as transpiler, the build currently fails:

Error: error building site: TOCSS-DART: failed to transform "scss/main.scss" (text/x-scss): "/home/user/docsy/assets/scss/support/_bootstrap_vers_test.scss:4:10": Expected ".

This is due to the fact that - contrary to libsass - dart sass does not support multi-line strings.

This PR fixes this issue.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

I thought that Hugo used Dart Sass now, given that libsass is deprecated.

@chalin
Copy link
Collaborator

chalin commented Jul 5, 2023

I'm not sure why the build is failing after a rebase.

@deining
Copy link
Collaborator Author

deining commented Jul 22, 2023

I'm not sure why the build is failing after a rebase.

After another rebase, the checker is green again 😄

@deining deining requested a review from chalin July 22, 2023 09:37
@chalin chalin merged commit a640e98 into google:main Jul 27, 2023
5 checks passed
@deining deining deleted the dart-sass branch July 27, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants