Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabpane: use data- attribute instead of class name #1607

Merged
merged 1 commit into from
Jul 5, 2023
Merged

tabpane: use data- attribute instead of class name #1607

merged 1 commit into from
Jul 5, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 5, 2023

  • Contributes to Tabpane shortcode fixes and enhancements (July) #1605
  • Switches to attaching the persistence key to tab HTML elements as a data- attribute rather than a CSS class name
  • Preserves converting the persistence key to lowercase, though now there's no longer a new to replace any characters
  • Other improvements to the JS to make it more robust

@chalin chalin requested a review from deining July 5, 2023 15:52
@chalin chalin mentioned this pull request Jul 5, 2023
Closed
7 tasks
deining
deining approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 397c5d4 into google:main Jul 5, 2023
5 checks passed
@chalin chalin deleted the chalin-im-tabpane-data-attr-2023-07-05 branch July 5, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deining deining deining approved these changes

Assignees
No one assigned
Labels
cleanup/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @deining