Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community_links.html #1621

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Update community_links.html #1621

merged 2 commits into from
Jul 15, 2023

Conversation

hcientist
Copy link
Contributor

@hcientist hcientist commented Jul 14, 2023

respect baseURL in template for community links (fixes #1622)

respect baseURL in template for community links
@google-cla
Copy link

google-cla bot commented Jul 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. See inline comment for tweaks.

layouts/partials/community_links.html Outdated Show resolved Hide resolved
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@deining deining merged commit 841b9a0 into google:main Jul 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community_links.html doesn't respect baseURL
3 participants