Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording with i18n/zh-tw.toml #1664

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Improve wording with i18n/zh-tw.toml #1664

merged 3 commits into from
Nov 13, 2023

Conversation

huanlin
Copy link
Contributor

@huanlin huanlin commented Aug 13, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Aug 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. See inline comments.

i18n/zh-tw.toml Show resolved Hide resolved
i18n/zh-tw.toml Show resolved Hide resolved
[print_show_regular]
other = "返回此頁面的常規視圖"
[print_entire_section]
other = "打印整個章節"
other = "列印整個章節"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -7,14 +7,14 @@ other = "上一頁"
other = "下一頁"

[ui_read_more]
other = "更多"
other = "閱讀全文"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

i18n/zh-tw.toml Show resolved Hide resolved
i18n/zh-tw.toml Show resolved Hide resolved
i18n/zh-tw.toml Show resolved Hide resolved
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all for the updates, your feedback, and reviews ✨

I can't rebase (probably because you named your branch PR main). After you rebase I'll merge.

@chalin chalin added this to the 23Q4 milestone Nov 13, 2023
@chalin
Copy link
Collaborator

chalin commented Nov 13, 2023

Finally, I was able to an update via merging.

@chalin chalin merged commit 889cd68 into google:main Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants