Algolia search, fix: point js + css file to specific version #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emckean
approved these changes
Sep 12, 2023
|
Confirming I'm seeing similar behavior. Docsearch seems to be broken in HEAD without this. |
froboy
added a commit
to YCloudYUSA/yusaopeny_docs
that referenced
this pull request
Oct 3, 2023
via https://www.docsy.dev/blog/2023/docsy-0.7/. body/head partials should be removed when google/docsy#1678 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently js + css file for algolia docsearch are pulled in via these URLs:
When pulling in these files, they are checked via a SRI hash. In both cases, SRI hashes are given for version 3.5.1. However, meanwhile @docsearch npm is at version 3.5.2. This means, that given SRI hashes are invalid now, algolia docsearch does not work and more.
This PR fixes this by pulling in specific version
3.5.2.