Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA4] Emit page_helpful events for page feedback #1726

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Nov 11, 2023

Preview, e.g.: https://deploy-preview-1726--docsydocs.netlify.app/docs/adding-content/feedback/#search-engine-optimization-meta-tags -- navigate to the end of the page to see the feedback form

@chalin chalin changed the title [GA4] Emit page_helpful events for page feedback [GA4] Emit page_helpful events for page feedback Nov 11, 2023
@chalin
Copy link
Collaborator Author

chalin commented Nov 11, 2023

/cc @fekete-robert

@chalin chalin force-pushed the chalin-im-page-helpful-event-2023-11-11 branch 4 times, most recently from 5b5c69b to c4348b9 Compare November 13, 2023 15:35
@chalin chalin added this to the 23Q4 milestone Nov 13, 2023
@fekete-robert
Copy link
Collaborator

I don't have a setup where I could actually test it, but LGTM

@chalin
Copy link
Collaborator Author

chalin commented Nov 13, 2023

Thanks for the feedback @fekete-robert. Right, we'll have to iterate, if necessary, given that preview builds don't include analytics. This code was in use in another one of our projects, so there's a good chance it'll work here too.

@geriom
Copy link
Collaborator

geriom commented Nov 14, 2023

I want to test this, it may take a couple of more days. If you need this merged sooner I can approve it.

Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin force-pushed the chalin-im-page-helpful-event-2023-11-11 branch from c4348b9 to 9dc1514 Compare November 14, 2023 18:12
@chalin chalin merged commit 885fad8 into google:main Nov 14, 2023
5 checks passed
@chalin chalin deleted the chalin-im-page-helpful-event-2023-11-11 branch November 14, 2023 18:23
@chalin
Copy link
Collaborator Author

chalin commented Nov 14, 2023

LOL, I forgot that we don't have analytics setup yet for the User Guide!

@chalin
Copy link
Collaborator Author

chalin commented Nov 14, 2023

I'll test as soon as I can and report here. (Since the UG isn't using this new feature, then there's no rush.)

@chalin
Copy link
Collaborator Author

chalin commented Nov 14, 2023

Ok, feature tested! page_helpful events are being emitted, with a value of 100 for "yes" responses. (Test results shared with PSC out-of-band.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants