Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabpane: update UG + CHANGELOG #1747

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Tabpane: update UG + CHANGELOG #1747

merged 1 commit into from
Nov 27, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Nov 17, 2023 •
edited
Loading

Preview: https://deploy-preview-1747--docsydocs.netlify.app/docs/adding-content/shortcodes/#shortcode-details

@chalin chalin mentioned this pull request Nov 17, 2023
Closed
9 tasks
@chalin
Copy link
Collaborator Author

chalin commented Nov 17, 2023

/cc @titusfortner

titusfortner
titusfortner approved these changes Nov 22, 2023
View reviewed changes
Copy link

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@deining deining added the user guide Improvements to user guide label Nov 23, 2023
@deining deining linked an issue Nov 23, 2023 that may be closed by this pull request
Tab pane: deprecation of option 'persistLang': CHANGELOG, user guide #1751
Closed
deining
deining approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin
Copy link
Collaborator Author

chalin commented Nov 27, 2023

Thanks for the reviews!

@chalin chalin merged commit 89b1048 into google:main Nov 27, 2023
5 checks passed
@chalin chalin deleted the chalin-im-tab-pane-cl+docs-2023-11-17 branch November 27, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titusfortner titusfortner titusfortner approved these changes

@deining deining deining approved these changes

@LisaFC LisaFC Awaiting requested review from LisaFC

Assignees
No one assigned
Labels
user guide Improvements to user guide
Projects
None yet
Milestone
No milestone
3 participants
@chalin @titusfortner @deining