css: fix an issue on .highlight pre border radius
#1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class .td-content.highlight has a border radius of 6px but .td-content.highlight pre had a border radius of 0. This fixes the visual discomfort of seing a square on a rounded border on codeblocks.
|
LGTM :) For an example, see the preview: https://deploy-preview-1762--docsydocs.netlify.app/docs/adding-content/shortcodes/ |
mtardy
added a commit
to cilium/tetragon
that referenced
this pull request
May 31, 2024
See PR google/docsy#1762 and upstream main commit google/docsy@0d3d631. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
added a commit
to cilium/tetragon
that referenced
this pull request
May 31, 2024
See PR google/docsy#1762 and upstream main commit google/docsy@0d3d631. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
added a commit
to cilium/tetragon
that referenced
this pull request
Jun 3, 2024
See PR google/docsy#1762 and upstream main commit google/docsy@0d3d631. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class .td-content.highlight has a border radius of 6px but .td-content.highlight pre had a border radius of 0. This fixes the visual discomfort of seing a square on a rounded border on codeblocks.
Notice the corners of codeblock, this thing has been annoying me for ages, notably on https://kubernetes.io and all the other websites using Docsy.
Before:
After:
