New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cpy-cli for OS-independent file copy #1810

Merged

chalin merged 1 commit into google:main from chalin:chalin-im-win-build-2024-02-02

Feb 2, 2024

Collaborator

chalin commented Feb 2, 2024

Proposed solution to Building under Windows #1793, which uses the popular NPM package cpy-cli to copy files rather than the Linux cp
Fixes 'npm run build' fails on Windows systems #973
Proposed alternatives to the following, which it closes:
- Closes npm install: get rid of platform dependent cp command #1797
- Closes [CI] Replace cp command by fs.copyFile + add test-all script #1806

/cc @marshalc @deining


          Use cpy-cli for OS-independent file copy

00c5a63

chalin added the CI/infra label

Collaborator Author

chalin commented Feb 2, 2024

Tests are all green, I'm going to run with this. I have one more round of NPM script tweaks. Comments are still welcome.

chalin merged commit edd2a0c into google:main

11 checks passed

chalin deleted the chalin-im-win-build-2024-02-02 branch

February 2, 2024 11:00

chalin mentioned this pull request

[CI] Improvements in CI and infra 24Q1 #1780

Closed

16 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment