Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Smoke tests: fix for repo forks, but also disable on push #1827

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 3, 2024

  • Fixes [CI] Smoke tests failing in repo forks #1826
  • Fixes tools/make-site.sh so that it can be run on repo forks, but ...
  • Restricts the execution of smoke jobs on push to the main repo -- we don't need tests to run again on forks.

@chalin chalin force-pushed the chalin-im-smoke-fork-fix-2024-02-03 branch from cb4d622 to 5fc5c2d Compare February 3, 2024 12:40
@chalin
Copy link
Collaborator Author

chalin commented Feb 3, 2024

I'm not 100% sure that the fix will work given the use of the script's fail-fast flag, but since we're disabling the job on forks anyways, I think it's safe to merge this now.

Edit: I confirm that it does work, e.g. when manually triggered, see https://github.com/chalin/docsy/actions/runs/7766979710/job/21183359040.

@chalin chalin merged commit 82622a2 into google:main Feb 3, 2024
11 checks passed
@chalin chalin deleted the chalin-im-smoke-fork-fix-2024-02-03 branch February 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Smoke tests failing in repo forks
1 participant