Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid diagram with diagram specific settings: fix 'uncaught TypeError' #1885

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Mar 6, 2024

This PR fixes the issue raised in #1882.
This PR closes #1882.

@deining deining added e1-hours fix Resolves some issue in the current code base labels Mar 6, 2024
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deining. See inline for suggested edits.

layouts/partials/scripts/mermaid.html Outdated Show resolved Hide resolved
layouts/partials/scripts/mermaid.html Outdated Show resolved Hide resolved
@chalin chalin added this to the 24Q1 milestone Mar 6, 2024
@deining deining requested a review from chalin March 6, 2024 22:04
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the fix ✨

@chalin chalin merged commit b0df3d9 into google:main Mar 6, 2024
11 checks passed
@deining deining deleted the fix-mermaid branch April 23, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e1-hours fix Resolves some issue in the current code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid graph with no parameters defined in hugo config results in 'Uncaught TypeError'
2 participants