Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding and modifying theme colors #1893

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 13, 2024

  • Fixes Support adding theme colors #1845
  • My hope is that the new placeholder file introduced by this PR will also be usable for color modes, but I haven't been able to test that out yet.

Preview: https://deploy-preview-1893--docsydocs.netlify.app/docs/adding-content/lookandfeel/#project-style-files

@fekete-robert
Copy link
Collaborator

LGTM, but hopefully I'll hope to test it during the weekend

@chalin chalin force-pushed the chalin-im-var-after-bs-2024-03-13 branch from 5b844a3 to cfeccd2 Compare March 14, 2024 22:48
Co-authored-by: Robert Fekete <fekete77.robert@gmail.com>
@chalin
Copy link
Collaborator Author

chalin commented Mar 15, 2024

Thanks all for the feedback.

@chalin chalin merged commit 1929a65 into google:main Mar 15, 2024
11 checks passed
@chalin chalin deleted the chalin-im-var-after-bs-2024-03-13 branch March 15, 2024 19:50
@rkranendonk
Copy link

Thanks for providing this fix! I'll try it out and will provide feedback from the perspective of the naive user

yann-soubeyrand pushed a commit to camptocamp/docsy that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support adding theme colors
4 participants