Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style adjustments in prep for dark mode support #1908

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 28, 2024

  • Contributes to Support dark mode #331 by generally this PR (re-)normalizing various styles to better match Bootstrap defaults, in preparation for the support of color modes.
  • Aside from alerts, the style changes aren't very noticeable, since colors are almost the same, etc.
  • Reverts alert background color to match BS default
  • Makes styling of code blocks uniform, whether it's highlighted or not
    • Makes copy-code button a bit more discrete
  • Misc cleanup of code blocks in a UG install page

Screenshots

Before:

image

After: from https://deploy-preview-1908--docsydocs.netlify.app/docs/get-started/other-options/#node-get-the-latest-lts-release

image

@chalin chalin added the design/style Front-end site design / styling label Mar 28, 2024
@chalin chalin mentioned this pull request Mar 28, 2024
26 tasks
@chalin
Copy link
Collaborator Author

chalin commented Mar 28, 2024

I'm going to merge these (visually) minor changes so that I can build upon them. Comments are still welcome @LisaFC @fekete-robert @deining et al.

@chalin chalin merged commit 7f0078c into google:main Mar 28, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-prep-2024-03-28 branch March 28, 2024 09:57
@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/style Front-end site design / styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant