New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark-mode] Tweak of param, file and resource names #1913

Merged

chalin merged 2 commits into google:main from chalin:chalin-im-dark-mode-contd-2024-03-30

Apr 5, 2024

Collaborator

chalin commented Apr 5, 2024 •

edited

Loading

Contributes to Support dark mode #331
Followup to Color-mode / dark-mode support #1909
Renames BS color-modes.js to dark-mode.js
Renames local-storage key so that it's Docsy specific
Relocates the light/dark-mode drop-down menu styles into the SCSS assets folder
Renames the config param to showLightDarkModeMenu

chalin added 2 commits

April 5, 2024 15:27


          [Dark-mode] Rename config param, relocate styles

60c5c3b


          Rename JS file, and local-storage key to be Docsy-specific

f893b50

chalin mentioned this pull request

Support dark mode #331

Closed

26 tasks

chalin added the enhancement label

Collaborator Author

chalin commented Apr 5, 2024

Going to merge now; more changes will follow.
@geriom, et al.: feedback is still welcome.

chalin merged commit 4e56448 into google:main

11 checks passed

chalin deleted the chalin-im-dark-mode-contd-2024-03-30 branch

April 5, 2024 19:43

chalin added this to the 24Q2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels