Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark-mode] Fixes for mobile #1917

Merged
merged 1 commit into from
Apr 6, 2024
Merged

[Dark-mode] Fixes for mobile #1917

merged 1 commit into from
Apr 6, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 6, 2024 •
edited
Loading

Preview, e.g.: https://deploy-preview-1917--docsydocs.netlify.app/docs/

Screenshots

Before

Note the menu title text (which we don't want). Also the dropdown doesn't drop down, which is why the screenshot doesn't show the dropdown menu open:

image
image

After

image
image

@chalin chalin mentioned this pull request Apr 6, 2024
Closed
26 tasks
@chalin
Copy link
Collaborator Author

chalin commented Apr 6, 2024

Going to merge this now. Feedback is still welcome.

@chalin chalin merged commit 6018506 into google:main Apr 6, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-mobile-2024-04-05 branch April 6, 2024 21:53
@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@fekete-robert
Copy link
Collaborator

fekete-robert commented Apr 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fekete-robert fekete-robert Awaiting requested review from fekete-robert

@deining deining Awaiting requested review from deining

@geriom geriom Awaiting requested review from geriom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q2
Development

Successfully merging this pull request may close these issues.

Light/dark-mode dropdown isn't visible under narrow displays
2 participants
@chalin @fekete-robert