Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark-mode] Firefox search text color fix #1918

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 6, 2024

Preview: https://deploy-preview-1918--docsydocs.netlify.app/docs/

Tested with:

  • Firefox 124.0.2 (64-bit)
  • Safari 17.4.1
  • Chrome 123.0.6312.107 (Official Build) (x86_64)

Screenshots using Firefox

Before

image

After

image

image

@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin chalin force-pushed the chalin-im-dark-mode-ff-fix-2024-04-06 branch from 9080555 to 4141f40 Compare April 6, 2024 22:34
@chalin chalin requested a review from deining April 7, 2024 21:15
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chalin chalin force-pushed the chalin-im-dark-mode-ff-fix-2024-04-06 branch from 4141f40 to 1ce1952 Compare April 8, 2024 08:24
@chalin chalin merged commit 820775e into google:main Apr 8, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-ff-fix-2024-04-06 branch April 8, 2024 09:27
@fekete-robert
Copy link
Collaborator

Thanks a lot, works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark mode] Text in the navbar search is dark under FireFox
3 participants