Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Fix top-nav position #2018

Merged
merged 2 commits into from
May 28, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 28, 2024

Important

This PR currently contains a TEMPORARY commit making en an RTL language so that this fix can be validated. DO NOT MERGE THIS TEMPORARY commit.

Screenshots

Before:

image

After:

image

@chalin chalin added the blocked label May 28, 2024
@chalin
Copy link
Collaborator Author

chalin commented May 28, 2024

@mboukhalfa @theletterf - PTAL

@chalin chalin changed the title [RTL] Fix top-nav position [TEMPORARY COMMIT INSIDE - DO NOT MERGE YET] - [RTL] Fix top-nav position May 28, 2024
@chalin chalin added this to the 24Q2 milestone May 28, 2024
@chalin chalin force-pushed the chalin-im-rtl-nav-auto-fix-2024-05-28 branch from 0cf2de9 to 142d1e7 Compare May 28, 2024 11:15
@chalin chalin changed the title [TEMPORARY COMMIT INSIDE - DO NOT MERGE YET] - [RTL] Fix top-nav position [RTL] Fix top-nav position May 28, 2024
@chalin chalin removed the blocked label May 28, 2024
@chalin
Copy link
Collaborator Author

chalin commented May 28, 2024

With a thumbs-up from @theletterf, I'm going to roll with it. @mboukhalfa if you have further concerns, let me know.

@chalin chalin merged commit b32bb90 into google:main May 28, 2024
11 checks passed
@chalin chalin deleted the chalin-im-rtl-nav-auto-fix-2024-05-28 branch May 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The menu does not switch sides when the site changes to RTL Incorrect auto margins on RTL languages
1 participant