Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Serbian language (cyrillic & latin) #2088

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

rammba
Copy link
Contributor

@rammba rammba commented Sep 28, 2024

Hello @chalin @deining, I'm glad to have a chance to contribute to this project.
I have translation experience mostly with Steam games, but also I recently started working on official React documentation together with @lxmarinkovic.

Copy link

google-cla bot commented Sep 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chalin chalin force-pushed the features/serbian-support branch from 146714a to 74c5e88 Compare October 1, 2024 22:18
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after checking most entries using a translation service. Thanks @rammba!

@chalin chalin merged commit 18e9053 into google:main Oct 1, 2024
11 checks passed
@rammba rammba deleted the features/serbian-support branch October 2, 2024 14:05
@chalin chalin added this to the 24Q4 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants