Removed pager when printing #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pager should not be presented in the printer page
|
@gwatts can you review? Thanks! |
|
i don't think i've seen a case where the pager did show up.. @dinotoa am i missing a case where this is actually needed; i'm sure i must be! |
|
@gwatts the pager appears in printed blog posts, see the attached pdf. Step to reproduce:
|
|
ahh i see - this only occurs when doing a regular "print page", vs using "print entire section" - i was only looking at the latter - Thanks for clarifying! This PR makes sense to me now - @LisaFC i think this is good! |
|
Thanks @gwatts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pager should not be presented in the printer page.
Added d-print-none style to avoid this problem.