Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap v5: initial work #517

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Conversation

deining
Copy link
Collaborator

@deining deining commented Apr 12, 2021

With official release bootstrap 5 coming soon, I just had a look at #470 to overcome the compatibility issues mentioned there.
It turned out to be quite easy, there was only one thing I had to fix as mentioned in the migration guide:

color-yiq() function and related variables are renamed to color-contrast()

With this PR applied, hugo runs with bootstrap 5. You may have a look at the netlify deploy associated with this PR.

I thought I share this already, though we should wait with the merge until bootstrap 5 is officially released. Maybe it is of help for others that want to play around with bootstrap 5 beta version already.

Preview: https://deploy-preview-517--docsydocs.netlify.app/

Contributes to:

@LisaFC
Copy link
Collaborator

LisaFC commented Apr 12, 2021

Oh, that's good that it's a simple fix! I'll try making the change to a site running on Netlify with the latest Bootstrap and Hugo versions and see what happens.

@deining
Copy link
Collaborator Author

deining commented Apr 12, 2021

I'll try making the change to a site running on Netlify with the latest Bootstrap and Hugo versions and see what happens.

Even easier: have a look at the netlify deploy associated with this PR. Overall it looks pretty good, but a few quirks need to be fixed:

  • The font for the text Welcome to Docsy on the start screen looks quite different.
  • The top heading is not perfectly aligned
  • For all documentation pages, the left margin of the main text area in the middle was reduced to zero.

@LisaFC
Copy link
Collaborator

LisaFC commented Apr 15, 2021

Ah yes, of course! And ooh yes, it seems like it's doing something very odd to some of our fonts and alignment. I'll play around with it and see what's happening in the generated HTML etc. Definitely won't move to v5 until we can come up with something that works with it and doesn't break formatting with v4.

@deining
Copy link
Collaborator Author

deining commented Apr 15, 2021

Definitely won't move to v5 until we can come up with something that works with it and doesn't break formatting with v4.

I fully understand and agree with this decision.
Bootstrap has accordion control implemented which look nice to me and could be useful in various places. Implementing shortcodes for accordions should be quite easy since their markup is quite similar to the tabbed panes we already have. I'm willing to contribute a PR once bootstrap 5 is out and integrated into docsy theme.

I'll play around with it and see what's happening in the generated HTML etc.

Looking forward to your findings! Good luck!

@LisaFC
Copy link
Collaborator

LisaFC commented Sep 27, 2021

@geriom can you figure out how/if you fixed this in Tekton?

@glasnt glasnt mentioned this pull request Dec 7, 2021
50 tasks
@chalin
Copy link
Collaborator

chalin commented Aug 18, 2022

@deining et all: Shall we use this as a base to move forward with the upgrade or create a new PR entirely? A lot has changed since this was originally submitted.

/cc @glasnt

@chalin chalin changed the title Update to latest bootstrap version (5.0.0-beta3) #470 Update to Bootstrap v5 #470 Aug 19, 2022
@chalin chalin force-pushed the bootstrap5 branch 3 times, most recently from 73228e9 to 8436f96 Compare August 19, 2022 00:57
@chalin
Copy link
Collaborator

chalin commented Aug 19, 2022

I've rebased and upgraded BS to v5.2.0. I'll then progressively work my way through the migration document and commit sectional changes as I go.

@deining deining force-pushed the bootstrap5 branch 2 times, most recently from 4aacb83 to 2dec6b9 Compare November 12, 2022 20:38
@deining deining force-pushed the bootstrap5 branch 2 times, most recently from cd61ee6 to c309d3a Compare December 4, 2022 09:07
@deining
Copy link
Collaborator Author

deining commented Dec 4, 2022

I've rebased and upgraded BS to v5.2.0. I'll then progressively work my way through the migration document and commit sectional changes as I go.

Great.

I just bumped BS to latest version v5.2.3 and Font-Awesome to version 6.2.1.

@chalin chalin changed the title Update to Bootstrap v5 #470 Update to Bootstrap v5 Jan 23, 2023
@chalin chalin changed the title Update to Bootstrap v5 Update to Bootstrap v5: initial work Jan 23, 2023
@chalin
Copy link
Collaborator

chalin commented Jan 23, 2023

As agreed out-of-band, I'll be merging this initial work.

@chalin chalin merged commit e936f7e into google:main Jan 23, 2023
@deining deining deleted the bootstrap5 branch January 28, 2023 08:29
dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
* Update to bootstrap v5: initial work
* Utilities: rename .ml-* and .mr-* to .ms-* and .me-*
* Bump bootstrap to latest version 5.2.3 (npm + module)

Co-authored-by: Patrice Chalin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants