Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build scripts, drop unused userguide files #728

Merged
merged 7 commits into from
Oct 29, 2021
Merged

Add build scripts, drop unused userguide files #728

merged 7 commits into from
Oct 29, 2021

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Oct 16, 2021

Basic prep for #726

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 16, 2021
@chalin
Copy link
Collaborator Author

chalin commented Oct 20, 2021

Build fixed -- sorry for not noticing that earlier. (Usually Netlify runs npm install on its own, but possibly because of the special setup this repo has, it doesn't seem to, so I added an explicit call to it.)

/cc @emckean

@chalin chalin force-pushed the chalin-build-scripts-2021-10-16 branch from 4c44ef2 to 907ba53 Compare October 26, 2021 19:22
@chalin
Copy link
Collaborator Author

chalin commented Oct 26, 2021

Branch has been rebased, and is ready for review @LisaFC and @emckean.

@chalin
Copy link
Collaborator Author

chalin commented Oct 28, 2021

Hi @LisaFC! Can this be merged soon? If not, is there anything specific holding it back & that I can help with? Thanks.

/cc @celestehorgan @nate-double-u

@LisaFC
Copy link
Collaborator

LisaFC commented Oct 28, 2021

Oops, sorry, that slipped through the net. I'll have a proper look shortly.

LisaFC
LisaFC reviewed Oct 28, 2021
View reviewed changes
netlify.toml Show resolved Hide resolved
@LisaFC LisaFC merged commit 802fe56 into google:master Oct 29, 2021
@chalin chalin deleted the chalin-build-scripts-2021-10-16 branch November 2, 2021 12:28
@LisaFC
Copy link
Collaborator

LisaFC commented Nov 2, 2021

OK, this seems to have broken the production build (preview builds are fine) - can you take a look? Looks like

https://app.netlify.com/sites/docsydocs/deploys/6181635e9c73ac0007af55eb

I'll have a poke around at it as well....

@LisaFC
Copy link
Collaborator

LisaFC commented Nov 2, 2021

Preview build for contrast: https://app.netlify.com/sites/docsydocs/deploys/61810d8c6e18950008232cd8

@chalin
Copy link
Collaborator Author

chalin commented Nov 2, 2021

Yes looking now.

@chalin
Copy link
Collaborator Author

chalin commented Nov 2, 2021

Found the issue. Preparing a fix.

@chalin
Copy link
Collaborator Author

chalin commented Nov 2, 2021

See #754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC left review comments

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chalin @LisaFC