Preparations for using docsy theme as hugo module #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
reviewed
Dec 17, 2021
| @@ -0,0 +1,228 @@ | |||
| // stylelint-disable property-blacklist, scss/dollar-variable-default | |||
There was a problem hiding this comment.
Why is this file being brought in separately as opposed to getting it via the module?
|
Can this be closed now that #806 was merged into the feature branch? |
Yes, this issue is obsolete now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using docsy theme as module was discussed previously (e.g. #283, #520). Feedback was encouraging, so I went ahead and I'm really close to a submit a PR that offers the possibility to use docsy theme as module. My module approach can coexist with the current submodule solution, so it's up to the user to decide which method to choose. I'm super excited and I see a lot of advantages when using modules (modules offer the possibility to check whether and extended hugo version is used, we can check for min version of hugo, we can pull in content from different repos, ...). This PR prepares the way for using docsy as module and is mandatory for my next PR which will turn docsy into a module. This PR contains one file only and is a workaround for a bug in the module handling of
golanguage.@LisaFC : Can you please merge this PR? Also, I intend to prepare the docsy-example site for using the theme as module, too. To avoid version confusion with bootstrap and Font-Awesome, it were good if PR 155 on the docsy-example repo could the processed, too. Thanks in advance.