Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure shortcodes work with old-Hugo and nu-Hugo #87

Merged
merged 6 commits into from
Jun 17, 2019
Merged

Conversation

LisaFC
Copy link
Collaborator

@LisaFC LisaFC commented Jun 11, 2019

No description provided.

@LisaFC
Copy link
Collaborator Author

LisaFC commented Jun 11, 2019

This should work....

@RichieEscarez
Copy link
Contributor

Sorry but I'm not sure why I'm having an impossible time replicating the issue (so im not able to validate this change)? I want back to Jan versions of the main _index.html and about/_index.html files (as well as the corresponding ....shortcodes/blocks/* files) but I could never get those elements to render vertically (tried on both Hugo 51 and 55.6)? Any suggestions?

@LisaFC
Copy link
Collaborator Author

LisaFC commented Jun 13, 2019

So about/_index.html was working fine on my local machine until I upgraded to 0.556, whereupon it stopped rendering the Markdown in those sections so they were just chunks of raw MD. I then "fixed" it with updated shortcodes, only to discover they didn't work with 0.53. The current arrangement as far as I can see works with both.

You would need to actually rewind the example site AND the template AND your Hugo version to see the original weirdly rendered horror, may not be worth it, and I'm pretty confident it's fine.

(the vertical rendering in blocks thing is a completely different issue that's got nothing to do with Hugo, it's just a default I need to switch in a forthcoming PR)

@LisaFC LisaFC merged commit 44d75fc into master Jun 17, 2019
@LisaFC LisaFC deleted the LisaFC-patch-2 branch June 17, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants