Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM script refactoring and README cmd adjustment #893

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 14, 2022

Other than cleaning up (refactoring) the user-guide NPM scripts, this also decouples docsy's npm install from the user-guide install. This is a better approach for #889.

/cc @geriom @LisaFC @emckean

@@ -10,18 +10,17 @@ being maintained.

The following are basic prerequisites for using Docsy in your site:

- Install a recent release of the Hugo "extended" version (we recommend version
0.53 or later). If you install from the [release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I removed the "(we recommend version 0.53 or later)", leaving at "a recent release" for now.

@chalin
Copy link
Collaborator Author

chalin commented Feb 14, 2022

Build is green, and generated HTML still looks good (including having the proper --baseURL). Merging so that I can rebase and resubmit #889.

@chalin chalin merged commit 438b56d into google:master Feb 14, 2022
@chalin chalin deleted the chalin-npm-script-rework-2022-02-14 branch February 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant