Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docu TL;DR: second module import path #970

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Conversation

Marzal
Copy link
Contributor

@Marzal Marzal commented Apr 9, 2022

path = "github.com/google/docsy" is duplicated, in 'Detailed conversion instructions' the right path is '"github.com/google/docsy/dependencies"'

path = "github.com/google/docsy" is duplicated, in 'Detailed conversion instructions' the right path is '"github.com/google/docsy/dependencies"'
@deining
Copy link
Collaborator

deining commented Apr 9, 2022

Your PR is valid, thanks for spotting this!
The same change should be applied in line 42 (Windows instructions).
Can you please add this change to your PR as well? Thanks!
Afterward this PR will be ready for merging.

@deining deining merged commit 7905e80 into google:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants