Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black bars on the left and right for blurry placeholder images #44

Closed
arjunsajeev opened this issue Oct 5, 2020 · 3 comments · Fixed by #45
Closed

Black bars on the left and right for blurry placeholder images #44

arjunsajeev opened this issue Oct 5, 2020 · 3 comments · Fixed by #45
Assignees
@cramforce

Comments

@arjunsajeev
Copy link

I am not sure if this is an issue or if I'm missing something. I noticed that the blurry placeholder image on the demo site had black bars on the left and right sides while loading and did not match the width of the original image. I was able to reproduce this locally as well.
@cramforce cramforce self-assigned this Oct 5, 2020
@cramforce
Copy link
Collaborator

I'll take a look

@cramforce
Copy link
Collaborator

Ah, yes. This appears to be happening with that image but not in general.

cramforce added a commit that referenced this issue Oct 6, 2020
@cramforce
Always scale the input image to desired output size.
d170476 
Fixes #44
@cramforce cramforce mentioned this issue Oct 6, 2020
Merged
cramforce added a commit that referenced this issue Oct 6, 2020
@cramforce
Always scale the input image to desired output size. (#45)
6e94253 
Fixes #44
@arjunsajeev
Copy link
Author

Awesome, thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always scale the input image to desired output size. google/eleventy-high-performance-blog
2 participants
@cramforce @arjunsajeev