Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch netlify function dependencies #49

Merged
merged 9 commits into from
Oct 19, 2020

Conversation

indcoder
Copy link
Contributor

When you fork the repo and go a clean deploy on netlify, we get an error that the Netlify function cannot find the dependencies

HackerspaceMumbai#30

This will lead to an issue that is open for more than a year on Netlify community

https://community.netlify.com/t/how-to-include-dependencies-in-netlify-lambda-functions/2323/18

Its an inconsistent error, for some site it does not error out while for others it will.

It looks like the best compromise is to have the Netlify function dependencies be defined the in the root xpackage.json since node.js traverses up the folder structure to find the node_modules directory with the requisite dependencies

@cramforce cramforce merged commit 681b936 into google:main Oct 19, 2020
@hhh968574
Copy link

ل

@inetbiz
Copy link

inetbiz commented Mar 13, 2022

@cramforce why would a sub domain from netflify be on the core file

origin.endsWith("-upbeat-shirley-608546.netlify.app") >= 0;
At least indicate a comment that the line should be deleted if one does not use netlfy?

@cramforce
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants