Prevent duplicate link rel prefetches and prefetching the current page #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent page. Add two checks against the prospective href to prefetch: 1. Has the href already been prefetched? 2. Is the href equal to the current page? There is not a benefit to duplicate prefetches or prefetching the current page. If either check is true, return without prefetching the href.
Your trial has endedChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
cramforce
requested changes
Nov 14, 2020
src/main.js
Outdated
| function prefetch(e) { | ||
| if (e.target.tagName != "A") { | ||
| return; | ||
| } | ||
| if (e.target.origin != location.origin) { | ||
| return; | ||
| } | ||
| if (window.location.pathname === e.target.pathname) { |
There was a problem hiding this comment.
This would also need to compare the query string. So, all of the URL except for the fragment.
src/main.js
Outdated
| if (window.location.pathname === e.target.pathname) { | ||
| return; | ||
| } | ||
| if (prefetched.includes(e.target.href)) { |
There was a problem hiding this comment.
Please remove. The way the prefetch cache works is that it will cache the returning resource for 5 minutes independent of its caching headers and duplicate fetches should not happen. If this is not the case, please provide a DevTools screenshot showing it and ideally file a crbug.com
added 2 commits
November 14, 2020 13:52
|
Thanks for your feedback! I removed the check for duplicate prefetch and updated the comparison to include query string (excluding the URL fragment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check against the prospective href to prefetch:
Is the href equal to the current page?