Address review feedback

google · Aug 13, 2023 · 4535778 · 4535778
1 parent 2ecedd4
commit 4535778
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
@@ -627,7 +627,7 @@ && exemptedFieldBySuperType(getType(variableTree), state)) {
           // to contain usage in that case, but parameter is always used implicitly
           // For compact canonical constructor parameters don't have record flag so need to
           // check constructor flags (`symbol.owner`) instead
-          if (hasRecordFlag(symbol) || hasRecordFlag(symbol.owner)) {
+          if (hasRecordFlag(symbol.owner)) {
             return null;
           }
           unusedElements.put(symbol, getCurrentPath());

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java
@@ -1385,7 +1385,7 @@ public void simpleRecord() {
     assumeTrue(RuntimeVersion.isAtLeast16());
     helper
         .addSourceLines(
-            "SimpleRecord.java",
+            "SimpleRecord.java", //
             "public record SimpleRecord (Integer foo, Long bar) {}")
         .expectNoDiagnostics()
         .doTest();