Fix ASTHelpers#isRuleKind on JDK versions without `CaseTree#getCase…

…Kind` Fixes #4479 (comment) PiperOrigin-RevId: 653615823
google · Jul 18, 2024 · 5c26d0d · 5c26d0d
1 parent 81d3127
commit 5c26d0d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java b/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java
@@ -2813,6 +2813,9 @@ private static Method getCaseTreeGetExpressionsMethod() {
    * <expression>}.
    */
   public static boolean isRuleKind(CaseTree caseTree) {
+    if (GET_CASE_KIND_METHOD == null) {
+      return false;
+    }
     Enum<?> kind;
     try {
       kind = (Enum<?>) GET_CASE_KIND_METHOD.invoke(caseTree);

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/TraditionalSwitchExpressionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/TraditionalSwitchExpressionTest.java
@@ -50,7 +50,6 @@ public void positive() {
 
   @Test
   public void negativeStatement() {
-    assumeTrue(RuntimeVersion.isAtLeast14());
     testHelper
         .addSourceLines(
             "Test.java",