Remove redundant calls to String.toString()

google · Jul 6, 2017 · 9aca2c8 · 9aca2c8
1 parent 91f625c
commit 9aca2c8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -15,6 +15,7 @@
 .idea/dataSources.ids
 .idea/codeStyleSettings.xml
 .idea/compiler.xml
+.idea/encodings.xml
 .idea/modules.xml
 .idea/uiDesigner.xml
 .idea/libraries

diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/HashtableContains.java b/core/src/main/java/com/google/errorprone/bugpatterns/HashtableContains.java
@@ -108,7 +108,7 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
   }
 
   private Fix replaceMethodName(MethodInvocationTree tree, VisitorState state, String newName) {
-    String source = state.getSourceForNode((JCTree) tree.getMethodSelect()).toString();
+    String source = state.getSourceForNode((JCTree) tree.getMethodSelect());
     int idx = source.lastIndexOf("contains");
     String replacement =
         source.substring(0, idx) + newName + source.substring(idx + "contains".length());

diff --git a/docgen/src/main/java/com/google/errorprone/BugPatternFileGenerator.java b/docgen/src/main/java/com/google/errorprone/BugPatternFileGenerator.java
@@ -204,7 +204,7 @@ public boolean processLine(String line) throws IOException {
                 .put("title", pattern.name)
                 .put("summary", pattern.summary)
                 .put("layout", "bugpattern")
-                .put("category", pattern.category.toString())
+                .put("category", pattern.category)
                 .put("severity", pattern.severity.toString())
                 .build();
         DumperOptions options = new DumperOptions();